-
Notifications
You must be signed in to change notification settings - Fork 43
Add ssm capability #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks Brad bringing up this new feature change. We are reviewing the feature support and the change. We will get back to you when we make any decision. |
|
@VikashKumarInd Can you give us a status update for this PR? |
|
any updates? |
| if region is not None: | ||
| region_cli = "--region {0}".format(region) | ||
|
|
||
| proxy_command = "ProxyCommand sh -c \"aws {0} ssm start-session --target %h --document-name AWS-StartSSHSession --parameters 'portNumber=%p'\"".format(region_cli) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Command should include the --profile argument if it was used when called mssh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it should adapt when executed on windows environments
ProxyCommand C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe "aws ssm start-session --target %h --document-name AWS-StartSSHSession --parameters portNumber=%p"
|
I've written an implementation works entirely inside of ssh config. No wrapper are needed. https://gist.github.com/Maks3w/de72b0160d5e6af958adc42eab014624 |
*Issue #5
Added flag to integrate with ssm. Also generates a temporary ssh_config file.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.