perf: avoid expensive call to Cipher.getInstance #2175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
No
Description of changes:
Pool usages of
Cipher.getInstancewhen used forCipherHandlerIn my (closed source) benchmark
This is POC code for comment. I am presuming the maintainers will have opinions on cache type/configuration, and refinements to the idea
In most usages the
CipherHandleris created, used and thrown away, but seems to be reused for the framed access, so some rework is probably needed there. Opinions welcomeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: