check for null headers in header callback #3659
Open
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3646
Description of changes:
When the S3Crt encounters a
AWS_ERROR_HTTP_CHANNEL_THROUGHPUT_FAILUREerror, we will segfault in the header callbacks because crt will pass use null headers. This checks for null headers and fails the callback if they are missing. This will allow the request to complete if the request has been configured to allow periods where no data is transferred by settings3CrtConfig.lowSpeedLimit = 0;.Check all that applies:
Creating a
AWS_ERROR_HTTP_CHANNEL_THROUGHPUT_FAILUREerror is not easy at test time and would require specific setup. The fix was manually tested and verified using the code from the initial ticket.Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.