Skip to content

Conversation

@sbiscigl
Copy link
Contributor

Issue #, if available:

#3646

Description of changes:

When the S3Crt encounters a AWS_ERROR_HTTP_CHANNEL_THROUGHPUT_FAILURE error, we will segfault in the header callbacks because crt will pass use null headers. This checks for null headers and fails the callback if they are missing. This will allow the request to complete if the request has been configured to allow periods where no data is transferred by setting s3CrtConfig.lowSpeedLimit = 0;.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
    Creating a AWS_ERROR_HTTP_CHANNEL_THROUGHPUT_FAILURE error is not easy at test time and would require specific setup. The fix was manually tested and verified using the code from the initial ticket.
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl force-pushed the s3crt-copy-obj-segfault branch from 4195091 to 0465025 Compare December 17, 2025 15:28
@sbiscigl sbiscigl marked this pull request as ready for review December 17, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants