Improve AWS Query compatible error handling in unmarshallers #4253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrsongg
reviewed
Dec 19, 2025
Contributor
peterrsongg
left a comment
peterrsongg
left a comment
There was a problem hiding this comment.
Verified it works in a console app myself. approved.
peterrsongg
reviewed
Dec 19, 2025
| "serviceName": "CloudWatch", | ||
| "type": "patch", | ||
| "changeLogMessages": [ | ||
| "Improve AWS Query compatible error handling in unmarshallers." |
Contributor
There was a problem hiding this comment.
Suggestion: Fix error handling for services running in aws query compatible mode, where the generic exception was being thrown instead of specific modeled exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified error response unmarshalling to directly update errorResponse object instead of using intermediate variables. For AWS Query compatible services, error codes are now extracted and set on the errorResponse object within the generate AWSQueryCompatibleBlock, this allowed us to remove conditional AWS Query compatible checks in
JsonRPCExceptionUnmarshallersince theerrorResponsealready contains the proper code and type.Motivation and Context
DOTNET-8439Testing
DRY_RUN-71a1a982-8709-48d3-a99a-c6d4c5251dd8Screenshots (if appropriate)
Types of changes
Checklist
License