Skip to content

Conversation

@yenfryherrerafeliz
Copy link
Contributor

Issue #2962
Allow object value within a member which type is document.

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Allow object value within a member which type is document.
@yenfryherrerafeliz
Copy link
Contributor Author

vendor/bin/behat --format=progress --tags=integ
...................................................................... 70
...................................................................... 140
...................................................................... 210
...................................................................... 280
...................................................................... 350
.......................................

113 scenarios (113 passed)
389 steps (389 passed)
13m48.54s (51.19Mb)
vendor/bin/behat --format=progress --suite=smoke --tags='~@noassumerole'
...................................................................... 70
...................................................................... 140
...................................................................... 210
............

111 scenarios (111 passed)
222 steps (222 passed)
1m45.17s (97.48Mb)

Copy link
Member

@stobrien89 stobrien89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be modifying values here- the intent is to validate. We might just simply do nothing if it's stdClass (json_encode() will handle it). In any case, I think we should discuss further. Setting validate to false in the client constructor will disable the validator, which will unblock them while we figure this out

Copy link
Member

@stobrien89 stobrien89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wrong about this. We should go with this change- just needs a changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants