Conversation
|
|
||
| ENV['RAILS_ENV'] = 'test' | ||
| require_relative 'dummy/config/application' | ||
| require 'rspec/rails' |
There was a problem hiding this comment.
necessary order change
|
Is there a reason to keep supporting end of life-d rails/ruby versions...? I feel like they should just be cut out/not officially supported. Will do the rubocop fixes. |
|
We can definitely consider a major version bump and drop old versions of Rails/Ruby. The SDK supports 2.5+ and in general we try to keep support where we can. We should keep the same matrix paradigm where we test every minor version of rails with ruby. |
|
I think it's reasonable to start at Rails 7, and Ruby 2.7 (minimum of Rails 7) |
|
@mullermp 👍🏻 Works for me. I'll make that change to the matrix and do the other things |
|
We should update the CI, README, VERSION, and gemspec for the major version bump possibly in yet another PR... I'd be happy to merge that quickly to unblock this one. |
|
#129 let's see if I did it right |
mullermp
left a comment
mullermp
left a comment
There was a problem hiding this comment.
Next I think it's just rubocop and see what CI does.
|
rubocop is running against all the old spec files since I renamed/changed all of them. I can fix all of them |
| spec.add_development_dependency('rspec-rails', '~> 6.1') | ||
|
|
||
| spec.required_ruby_version = '>= 2.5' | ||
| spec.required_ruby_version = '>= 2.7' |
mullermp
left a comment
mullermp
left a comment
There was a problem hiding this comment.
There's some in the rubocop todo if you are feeling adventurous. If not, I think we can move on to the other PR now.
mullermp
changed the title
|
I don't know if I merged this prematurely or not. I see in the other PR actually that you've converted actual tests to use RSpec.describe and new syntax! Let me know if that's the case. |
|
@mullermp I can just do that in the other PR/keep changes, when I was working on it there I didn't realize I didn't have to to MVP get it done lolol. |
|
@mullermp this is good to get merged, IMO. |
2 participants
Convert to rspec for tests (broken out from #127 for sanity)
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.