Use node instance role credentials for Pod Identity Agent as credenti…#83
Open
Use node instance role credentials for Pod Identity Agent as credenti…#83
Conversation
yue9944882
reviewed
Jun 9, 2025
| } | ||
|
|
||
| // CustomDefaultCredentialsProvider returns a provider that tries static env vars first, then IMDS | ||
| func CustomDefaultCredentialsProvider(cfg aws.Config) aws.CredentialsProvider { |
Contributor
There was a problem hiding this comment.
is this the right implementation? FMU the env var based AWS creds are not rotatable. instead of implementing our own cred provider, can we reuse the existing ones?
yue9944882
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…al provider
Issue #, if available:
Description of changes:
Use node instance role credentials for Pod Identity Agent as credential provider
EKS Pod Identity is using the host network, IMDS will use node instance role as credential provider, which includes the permission to call assume-role-for-pod-identity.
We don't want container credential provider to take precedence over instance role credential provider.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.