Fix: "My Virtual Desktop" view shows other users' desktops #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `value` filter for the `owner` field with `eq` filter in the `list_all_for_user` function. Added additional `owner` filtering in `fetchUserSessions` function. "My Virtual Desktop" view incorrectly showed all Virtual Desktops whose "owner" field contained the user's username. For example, user `an` can view all of user `ryan`'s Virtual Desktops, regardless of user's permissions.
|
@emmalion93 did you create an issue to document the bug? I believe that is the first step in the contribution guidelines. |
Author
|
@electroniceagle It looks like something went wrong when we originally tried to submit the issue. I have created a new issue to document this bug: #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where "My Virtual Desktop" view incorrectly showing all Virtual Desktops whose "owner" field contained the user's username. For example, user
mincan view all of userClusteradmin's Virtual Desktops, regardless of permissions.Issue:
Clusteradminuser's "My Virtual Desktop" view correctly shows the Virtual Desktop launched by theClusteradminuser:minuser's "My Virtual Desktop" view incorrectly shows the Virtual Desktop deployed by theClusteradminuserChange log:
valuefilter for theownerfield witheqfilter in thelist_all_for_userfunction.ownerfiltering in thefetchUserSessionsfunction.How was this PR tested?
Manual test:
Clusteradminaccountminand synced the changes in the Cognito Database with AWS RES using thecognito-sync-lambdaminusername and passwordminuser's "My Virtual Desktop" view did not show theClusteradminuser's Virtual DesktopClusteradmin"My Virtual Desktop" view:min"My Virtual Desktop" view:License
Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.te this contribution, under the terms of your choice.