Conversation
…tifiers extends to all CDT literals within a file as well as to the file itself; as per awslabs/SPARQL-CDTs#2 and awslabs/SPARQL-CDTs#4
|
I will review them soon.
Interesting test. I'm not sure For what it's worth, my implementation currently fails 9 out of the 73 tests. |
|
I have worked on my implementation the last two days and it passes all these tests now, except for the STRDT test. I didn't necessarily mean that we need to include this test. It is just something that came to my mind and I wanted to bring it up. We may also include the inverse of this test. |
…tifiers extends to all CDT literals within a file as well as to the file itself; as per awslabs/SPARQL-CDTs#2 and awslabs/SPARQL-CDTs#4
|
OK. I've now gone over all of the tests. My code now also passes all tests except |
|
Thanks for checking the tests! I have removed |
…tifiers extends to all CDT literals within a file as well as to the file itself; as per awslabs/SPARQL-CDTs#2 and awslabs/SPARQL-CDTs#4
This PR adds several tests related to the spec text that we are still working on in PR #2. That is, these tests are about blank node identifies, reading them from one or multiple Turtle files, from SPARQL queries, or from both Turtle files and SPARQL queries.
@kasei please review. I think most of them are quite straightforward. The only one that is probably controversial is
:bnodes-sparql-10which uses the following query.I am unsure myself about this one. It just came to my mind that something like this is possible and there may be expectations for this to work. Yet, strictly speaking, this test should not pass; not according to the current spec text that we have in PR #2 because that spec text focuses only on cdt:List and cdt:Map literals that are given directly with their lexical forms. So, perhaps, the correct version of this test should say
FILTER( ?e1 != ?e2 )instead ofFILTER( ?e1 = ?e2 )!?