Changes list-equal and map-equal for cases with the same blank node#5
Merged
Changes list-equal and map-equal for cases with the same blank node#5
Conversation
…e blank node lead to true rather than an error
hartig
added a commit
to hartig/jena
that referenced
this pull request
May 28, 2024
Contributor
Author
|
@kasei can you please take a look at this one as well. This shouldn't take too long as we agreed to this change in our Slack conversation. |
Collaborator
|
Looks good. Making the change to the algorithm in my code lets me pass the updated tests. Good to merge. |
kasei
approved these changes
Jun 4, 2024
Contributor
Author
|
Thanks for checking! |
hartig
added a commit
to hartig/jena
that referenced
this pull request
Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to PR #2, the definitions of
list-equalandmap-equalneed to be changed as follows. Currently, during the pairwise comparison of elements of the given two lists, whenever at least one of the two elements is a blank node, the overall=comparison of the two lists literals results in an error. The required change (as implemented by this PR) is: If both of the elements happen to be the same blank node, then there should be no error. Similarly, for maps.This PR changes the corresponding steps in the algorithms that define the expected behavior of
list-equal(Section 5.1) and ofmap-equal(Section 5.2). Additionally, this PR changes the corresponding tests.