Skip to content

Replace : character with / in logGroupName because : is invalid #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grisanu wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Replace : character with / in logGroupName because : is invalid #160

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0a7177
Replace : character with / in logGroupName because : is invalid
grisanu Mar 28, 2024
483c2bf
Merge branch 'master' into grisanu/format-log-group-name
grisanu Feb 27, 2025
43ab511
Merge branch 'master' into grisanu/format-log-group-name
grisanu Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/environment/ECSEnvironment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ const formatImageName = (imageName: string): string => {
return imageName;
};

// logGroupName must satisfy regular expression pattern: [\\.\\-_/#A-Za-z0-9]+
const formatLogGroupName = (logGroupName: string): string => {
Copy link
Member

@gordonpn gordonpn Mar 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this method name accurately describe what the method is doing.

return logGroupName.replace(":", "/");
Copy link
Member

@gordonpn gordonpn Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have unit tests for this.

}

export class ECSEnvironment implements IEnvironment {
private sink: ISink | undefined;
private metadata: IECSMetadataResponse | undefined;
Expand Down Expand Up @@ -114,7 +119,9 @@ export class ECSEnvironment implements IEnvironment {
return '';
}

return config.logGroupName || this.getName();
const logGroupName = config.logGroupName || this.getName()

return formatLogGroupName(logGroupName);
}

public configureContext(context: MetricsContext): void {
Expand Down