Skip to content

update import statements for downstream esm compatibility #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
modern-dev-dude wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update import statements for downstream esm compatibility #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c6abbf
replaced removed import = and replaced with import from
modern-dev-dude Nov 21, 2024
84e3481
removed importof Console and modified constructor to use global scope
modern-dev-dude Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sinks/AgentSink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* limitations under the License.
*/

import url = require('url');
import url from 'url';

import Configuration from '../config/Configuration';
import { MetricsContext } from '../logger/MetricsContext';
Expand Down
6 changes: 3 additions & 3 deletions src/sinks/ConsoleSink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
* limitations under the License.
*/

import { Console } from 'console';
import { MetricsContext } from '../logger/MetricsContext';
import { LogSerializer } from '../serializers/LogSerializer';
import { ISerializer } from '../serializers/Serializer';
Expand All @@ -25,7 +24,6 @@ import { ISink } from './Sink';
*/
export class ConsoleSink implements ISink {
public readonly name: string = 'ConsoleSink';

private serializer: ISerializer;
public readonly console: Console;
private static readonly AWS_LAMBDA_LOG_FORMAT = 'AWS_LAMBDA_LOG_FORMAT';
Expand All @@ -35,7 +33,9 @@ export class ConsoleSink implements ISink {

// To avoid escaping EMF when using Lambda JSON log format we need to use Console() instead of console
this.console =
process.env[ConsoleSink.AWS_LAMBDA_LOG_FORMAT] === 'JSON' ? new Console(process.stdout, process.stderr) : console;
process.env[ConsoleSink.AWS_LAMBDA_LOG_FORMAT] === 'JSON'
? new console.Console(process.stdout, process.stderr)
: console;
}

public accept(context: MetricsContext): Promise<void> {
Expand Down