chore: Setting the default spark_version value from pyspark.__version__ #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenliu0831
reviewed
Nov 29, 2023
Contributor
chenliu0831
left a comment
chenliu0831
left a comment
There was a problem hiding this comment.
Thanks - I think this is an acceptable solution (although not airtight :)). A few comments
Contributor
|
Test is failing - @Argo3V5A would you take a look? |
chenliu0831
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #170
Description of changes:
The default value for the SPARK_VERSION variable will be taken from
pyspark.__version__. In case of problems, the user also sets the environment variable himselfBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.