Implement isPrimaryKey check, fix and refactor check tests #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

nikie wants to merge 2 commits into awslabs:master from nikie:checks-isPrimaryKey-n-tests

nikie commented Jun 5, 2025 •

edited

Loading

Issue #, if available:
#249

Description of changes:

This finishes the isPrimaryKey check implementation.
All tests in tests/test_checks.py are fixed and refactored as follows:
- pytest.mark.xfail marks are removed (according to pytest docs they are meant for cases when feature is not yet implemented or there is a new bug which cannot be fixed yet; also with such marks on tests with multiple asserts it is not obvious which asserts are supposed to fail);
- "Success" and "Failure" checks are rearranged so that the former are grouped in test_<check> and the latter - in test_fail_<check> methods;
- previously commented out tests are implemented with better assertion functions;
- new run_check helper to simplify check tests;
- some duplicated tests are removed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nikie added 2 commits

June 5, 2025 20:14


          Implement isPrimaryKey check.

1af641e


          Fix and refactor checks tests.

8744fd4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet