feat(rework): implement fix-bug
#163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TuDo1403
force-pushed
the
implement-feature/rework/fix-bug
branch
from
566902b to
b3a3d22
Compare
huyhuynh3103
reviewed
Jan 2, 2025
huyhuynh3103
reviewed
Jan 2, 2025
huyhuynh3103
reviewed
Jan 2, 2025
huyhuynh3103
reviewed
Jan 2, 2025
| proxyInfo.callValue = callValue; | ||
| proxyInfo.by = implInfo.by; | ||
| proxyInfo.contractName = "TransparentProxyOZv4_9_5"; | ||
| proxyInfo.contractName = "RoninTransparentProxy"; |
Contributor
There was a problem hiding this comment.
The new proxy should be audited before going live
huyhuynh3103
reviewed
Jan 2, 2025
Contributor
huyhuynh3103
left a comment
huyhuynh3103
left a comment
There was a problem hiding this comment.
should bring the unit tests for the Transparent Proxy from OZ into here to ensure the logic behaves as expected
…adapt new forge version when generating storage layout
Co-authored-by: HuyHuynh <63286199+huyhuynh3103@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to merge from implement-feature/rework/fix-bug to feature/rework.