fix bugs generated by _steps null in discoverFeatures and _alreadyCompletedSteps methods#42
fix bugs generated by _steps null in discoverFeatures and _alreadyCompletedSteps methods#42frsisalima wants to merge 11 commits intoayalma:masterfrom
Conversation
|
Conflicting files |
|
Is this pr stopped? |
This file shouldn't even be in VCS. |
|
@ayalma will you merge this PR anytime soon? Your package is unusable without addressing this issue. |
lib/src/foundation/bloc.dart
Outdated
| _steps = steps; | ||
| _stepsToIgnore = await _alreadyCompletedSteps; | ||
| _steps = _steps.where((s) => !_stepsToIgnore.contains(s)).toList(); | ||
| _steps = _steps!=null?_steps.where((s) => !_stepsToIgnore.contains(s)).toList():[]; |
There was a problem hiding this comment.
What's your problem with spacing? :)
There was a problem hiding this comment.
I don't know what is the problem, the log error is:
lib/src/foundation/bloc.dart
lib/src/rendering/custom_layout.dart
test/feature_discovery_test.dart
Formatting failed: 1
Error: Process completed with exit code 1.
|
You should run |
lib/src/foundation/bloc.dart
Outdated
| _steps = _steps.where((s) => !_stepsToIgnore.contains(s)).toList(); | ||
| _steps = _steps != null | ||
| ? _steps.where((s) => !_stepsToIgnore.contains(s)).toList() | ||
| : []; |
There was a problem hiding this comment.
This could be rewritten nicely like so:
_steps = _steps?.where((s) => !_stepsToIgnore.contains(s)).toList() ?? [];
lib/src/foundation/bloc.dart
Outdated
| ? _steps | ||
| .where((s) => prefs.getBool('$sharedPrefsPrefix$s') == true) | ||
| .toSet() | ||
| : {}; |
There was a problem hiding this comment.
Same here:
return _steps?.where((s) => prefs.getBool('$sharedPrefsPrefix$s') == true).toSet() ?? {};
One test is still failing because of formatting, maybe run it again. |
|
Can we please merge this PR? A small linting issue is making this great library unusable. |
|
Will this PR be waiting? |
6 participants
fix bugs generated by _steps null in discoverFeatures and _alreadyCompletedSteps methods