Skip to content

Move thread choosing logic to callback closure #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jeehut wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Move thread choosing logic to callback closure #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ba4f5a
Revert "Revert comment to main thread call"
Jeehut Apr 30, 2016
1014004
Revert "Revert to main thread call"
Jeehut Apr 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Polyglot/Polyglot.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ public class Polyglot {
}

/**
Translates a given piece of text.
Translates a given piece of text asynchronously. Switch to the main thread within the callback
if you want to update your UI by using `dispatch_async(dispatch_get_main_queue()) { /* code */ }`.

- parameter text: The text to translate.
- parameter callback: The code to be executed once the translation has completed.
Expand Down Expand Up @@ -169,9 +170,7 @@ public class Polyglot {
translation = self.translationFromXML(xmlString)

defer {
dispatch_async(dispatch_get_main_queue()) {
callback(translation: translation)
}
callback(translation: translation)
}
}
task.resume()
Expand Down
6 changes: 4 additions & 2 deletions PolyglotTests/PolyglotTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,10 @@ class PolyglotTests: XCTestCase {

let polyglot: Polyglot = Polyglot(clientId: "myClientId", clientSecret: "myClientSecret")
polyglot.translate("Ik weet het niet") { translation in
XCTAssertEqual(translation, "I don't know")
expectation.fulfill()
dispatch_async(dispatch_get_main_queue(), { () -> Void in
XCTAssertEqual(translation, "I don't know")
expectation.fulfill()
})
}

waitForExpectationsWithTimeout(1, handler: nil)
Expand Down