Skip to content

Allow data URLs for Chart icons #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benbz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow data URLs for Chart icons #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pyhelm3/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
FilePath,
AnyUrl as PydanticAnyUrl,
HttpUrl as PydanticHttpUrl,
UrlConstraints,
constr,
field_validator
)
Expand Down Expand Up @@ -61,10 +62,13 @@ def validate_str_as(validate_type):
adapter = TypeAdapter(validate_type)
return lambda v: str(adapter.validate_python(v))

class PydanticDataUrl(PydanticAnyUrl):
_constraints = UrlConstraints(allowed_schemes=["data"])

#: Annotated string types for URLs
AnyUrl = t.Annotated[str, AfterValidator(validate_str_as(PydanticAnyUrl))]
HttpUrl = t.Annotated[str, AfterValidator(validate_str_as(PydanticHttpUrl))]
DataUrl = t.Annotated[str, AfterValidator(validate_str_as(PydanticDataUrl))]


class ChartDependency(BaseModel):
Expand Down Expand Up @@ -173,7 +177,7 @@ class ChartMetadata(BaseModel):
default_factory = list,
description = "List of maintainers for the chart."
)
icon: t.Optional[HttpUrl] = Field(
icon: t.Optional[HttpUrl | DataUrl] = Field(
None,
description = "URL to an SVG or PNG image to be used as an icon."
)
Expand Down