Skip to content

Use distinct type for dependencies' aliases & names#37

Open
benbz wants to merge 1 commit intoazimuth-cloud:mainfrom
element-hq:bbz/split-dependency-names
Open

Use distinct type for dependencies' aliases & names#37
benbz wants to merge 1 commit intoazimuth-cloud:mainfrom
element-hq:bbz/split-dependency-names

Conversation

@benbz
Copy link

@benbz benbz commented Nov 3, 2025

When helm install/helm upgrade the name of dependencies returned with --output json is replaced by their alias (if any).

e.g. https://github.com/goauthentik/helm/blob/authentik-2025.10.0/charts/authentik/Chart.yaml#L40-L44

  - name: authentik-remote-cluster
    repository: https://charts.goauthentik.io
    version: 2.1.0
    condition: serviceAccount.create
    alias: serviceAccount

Results in:

$ helm upgrade -i authentik --output json oci://ghcr.io/goauthentik/helm-charts/authentik:2025.10.0 | jq '.chart.metadata.dependencies[0]'
Pulled: ghcr.io/goauthentik/helm-charts/authentik:2025.10.0
Digest: sha256:8b617e3bcb9f9988fe0be8428cf1f78489236e1a73385cfdd692517a0d269435
{
  "name": "serviceAccount",
  "version": "2.1.0",
  "repository": "https://charts.goauthentik.io",
  "condition": "serviceAccount.create",
  "enabled": true,
  "alias": "serviceAccount"
}

ChartDependency.alias allows an arbitrary non-empty string to be used, so ChartDependency.name needs to match this. #9 attempted to resolve this via changing the Name type, this PR just loosens the restrictions on dependencies[].{name,alias}.

Alternatively this PR could be taken further and impose the restrictions from #9 to just dependencies[].{name,alias}.

Edit: whops I forgot #31 exists. This PR would solve the issue #31 is having, but #31 would need slightly looser restrictions (allowing A-Z too) to solve the problem I'm having with Authentik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments