Use distinct type for dependencies' aliases & names#37
Open
benbz wants to merge 1 commit intoazimuth-cloud:mainfrom
Open
Use distinct type for dependencies' aliases & names#37benbz wants to merge 1 commit intoazimuth-cloud:mainfrom
benbz wants to merge 1 commit intoazimuth-cloud:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
helm install/helm upgradethe name of dependencies returned with--output jsonis replaced by their alias (if any).e.g. https://github.com/goauthentik/helm/blob/authentik-2025.10.0/charts/authentik/Chart.yaml#L40-L44
Results in:
ChartDependency.aliasallows an arbitrary non-empty string to be used, soChartDependency.nameneeds to match this. #9 attempted to resolve this via changing theNametype, this PR just loosens the restrictions ondependencies[].{name,alias}.Alternatively this PR could be taken further and impose the restrictions from #9 to just
dependencies[].{name,alias}.Edit: whops I forgot #31 exists. This PR would solve the issue #31 is having, but #31 would need slightly looser restrictions (allowing
A-Ztoo) to solve the problem I'm having with Authentik