Skip to content

Helm 4: Support --rollback-on-failure #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaelgatelement wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Helm 4: Support --rollback-on-failure #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9664c54
Helm 4: Support --rollback-on-failure
gaelgatelement Feb 4, 2026
10cd265
detect helm version and adjust args parameters
gaelgatelement Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pyhelm3/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ async def install_or_upgrade_release(
chart: Chart,
*values: t.Dict[str, t.Any],
atomic: bool = False,
rollback_on_failure: bool = False,
cleanup_on_fail: bool = False,
create_namespace: bool = True,
description: t.Optional[str] = None,
Expand All @@ -243,6 +244,7 @@ async def install_or_upgrade_release(
chart.ref,
mergeconcat(*values) if values else None,
atomic = atomic,
rollback_on_failure = rollback_on_failure,
cleanup_on_fail = cleanup_on_fail,
create_namespace = create_namespace,
description = description,
Expand Down Expand Up @@ -344,6 +346,7 @@ async def ensure_release(
chart: Chart,
*values: t.Dict[str, t.Any],
atomic: bool = False,
rollback_on_failure: bool = False,
cleanup_on_fail: bool = False,
create_namespace: bool = True,
description: t.Optional[str] = None,
Expand Down Expand Up @@ -381,6 +384,7 @@ async def ensure_release(
chart,
values,
atomic = atomic,
rollback_on_failure = rollback_on_failure,
cleanup_on_fail = cleanup_on_fail,
create_namespace = create_namespace,
description = description,
Expand Down
9 changes: 7 additions & 2 deletions pyhelm3/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,7 @@ async def install_or_upgrade(
values: t.Optional[t.Dict[str, t.Any]] = None,
*,
atomic: bool = False,
rollback_on_failure: bool = False,
cleanup_on_fail: bool = False,
create_namespace: bool = True,
description: t.Optional[str] = None,
Expand Down Expand Up @@ -546,8 +547,12 @@ async def install_or_upgrade(
# We send the values in on stdin
"--values", "-",
]
if atomic:
command.append("--atomic")
if atomic or rollback_on_failure:
helm_binary_version = await self.version()
if helm_binary_version.startswith("v4"):
command.append("--rollback-on-failure")
else:
command.append("--atomic")
if cleanup_on_fail:
command.append("--cleanup-on-fail")
if create_namespace:
Expand Down