Support both 4.2 and older versions and fix an exception#58
Open
kwsxing wants to merge 2 commits intob-init:mainfrom
Open
Support both 4.2 and older versions and fix an exception#58kwsxing wants to merge 2 commits intob-init:mainfrom
kwsxing wants to merge 2 commits intob-init:mainfrom
Conversation
Collaborator
|
Thank you so much for your contribution, and I apologize for the delayed response. Your work is incredibly valuable, especially with the need for regular updates to ensure compatibility with each new Blender release. Unfortunately, I've been away from Blender and its Python API for quite some time and don’t feel confident enough to review this PR thoroughly. If possible, @b-init might be able to assist with the review. Thank you again, and I apologize for the inconvenience. |
|
without adding pressure @b-init and @thanhph111, I've taken a look and this passes my review ;) @kwsxing's code is what I'm currently running on my blender instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
File -> Defaults -> Save Startup FileScreenshots/Screencasts
Below is the exception in Blender 3.5 and 4.2: