Skip to content

added FindByTestId #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
linkdotnet merged 3 commits into from
Jan 1, 2026
Merged

added FindByTestId #1802

linkdotnet merged 3 commits into from
Jan 1, 2026

Conversation

@jimSampica
Copy link
Contributor

@jimSampica jimSampica commented Dec 31, 2025 •
edited
Loading

added FindByTestId to bunit.web.query based on discussion from #1359

@jimSampica jimSampica changed the title feat: added FindByTestId added FindByTestId Dec 31, 2025
@jimSampica
Copy link
Contributor Author

jimSampica commented Dec 31, 2025

@dotnet-policy-service agree

linkdotnet
linkdotnet previously approved these changes Dec 31, 2025
View reviewed changes
Copy link
Collaborator

@linkdotnet linkdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Small nitpick from my side.
Also, can you add an entry under: UNRELEASED
Basically, add a new ### ADDED section where you add the new functionality.

Something along:

## UNRELEASED
+
+ ### ADDED
+ - `FindByTestId` to `bunit.web.query` to gather elements by a given test id. By [@jimSampica](https://github.com/jimSampica)

@jimSampica
Copy link
Contributor Author

jimSampica commented Dec 31, 2025

Looking good! Small nitpick from my side. Also, can you add an entry under: UNRELEASED Basically, add a new ### ADDED section where you add the new functionality.

Something along:

## UNRELEASED
+
+ ### ADDED
+ - `FindByTestId` to `bunit.web.query` to gather elements by a given test id. By [@jimSampica](https://github.com/jimSampica)

Should be addressed now ☺️

@linkdotnet
Copy link
Collaborator

linkdotnet commented Jan 1, 2026

Looking good! So let's get that in as a new years celebration!

@linkdotnet linkdotnet merged commit e686527 into bUnit-dev:main Jan 1, 2026
1 check passed
@jimSampica jimSampica deleted the by-testid branch January 2, 2026 16:07
@scottsauber
Copy link
Collaborator

scottsauber commented Jan 4, 2026

Yay @jimSampica!

linkdotnet added a commit that referenced this pull request Jan 8, 2026
@linkdotnet @jimSampica
Release of new minor version v2.5 (#1803)
68599cd 
* Set version to '2.5-preview'

* feat: Added FindByTestId (#1802)

* fix: Add OverloadResolutionAttribute for Render method in .NET 9.0+ (#1801)

* Set version to '2.5'

---------

Co-authored-by: Jim Sampica <jtsampica@gmail.com>
Co-authored-by: Steven Giesel <stgiesel35@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linkdotnet linkdotnet linkdotnet left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jimSampica @linkdotnet @scottsauber