Fix settings tab crash issue #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When a user tries to click on the settings tab, the app crashes and becomes unusable.
Root Cause
The crash was occurring because the SettingsViewController was attempting to apply LED effects to table view cells before the view was fully initialized. Additionally, there were missing safety checks when accessing table data arrays, which could lead to index out of bounds exceptions.
Changes Made
Testing
The settings tab should now load properly without crashing, and all LED effects should still be applied correctly once the view is fully initialized.
💻 View my work • About Codegen