-
Notifications
You must be signed in to change notification settings - Fork 99
feat: Structured review workflow (tags, MACRO, annotate, markers, evolution) #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
theflysurfer
wants to merge
9
commits into
backnotprop:main
Choose a base branch
from
theflysurfer:feature/merged-0.6.7
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ReviewTag enum with modification/verification/validation categories - Add [MACRO] flag for cross-document impact annotations - Add tag dropdown in AnnotationToolbar - Add [MACRO] toggle button with warning styling - Display tags and [MACRO] badges in AnnotationPanel - Include tags and [MACRO] in exportDiff feedback - Add Save Markers button (annotate mode) to persist validation markers - Add /api/save-markers endpoint in annotate server - Add extractValidationMarkers/injectValidationMarkers in markers.ts - Add plannotator annotate <file> subcommand - Add /plannotator-annotate slash command - Add version tracking with planVersions Map Co-Authored-By: Claude <noreply@anthropic.com>
Upstream changes (v0.6.5-v0.6.7): - Add Comment mode and type-to-comment shortcut (backnotprop#93, backnotprop#97) - Smart detection for agent switching in OpenCode (backnotprop#96) - Use primary_tools config for sub-agent blocking (backnotprop#95) - OpenCode plugin updates (CVE + sub-agent fix) (backnotprop#90) - Increase hook timeout to 4 days (backnotprop#88) - Preserve newlines in copy and add Cmd+C shortcut (backnotprop#87) Custom features preserved: - Review methodology tags (@todo, @fix, @verify, etc.) - [MACRO] flag for cross-document impact annotations - Annotate mode for arbitrary markdown files - Persistent validation markers (Save Markers button) - @plannotator/core package with shared types Conflict resolution: - packages/ui/types.ts: Keep re-export from @plannotator/core - packages/core/types.ts: Add 'comment' to EditorMode - bun.lock: Regenerated Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
- Remove build:opencode from package.json scripts - Update CLAUDE.md to remove OpenCode documentation - Simplify build command to just build:hook Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
In annotate mode, there's no plan to approve - only feedback to send. The Approve button and its separator are now hidden when mode=annotate. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
- Use PLANNOTATOR_CWD env var to get original working directory - Strip @ prefix from file paths (Claude Code reference syntax) - Add debug logging (PLANNOTATOR_DEBUG=1) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Script is hard-linked to ~/.claude/scripts/ for Claude Code integration. Handles Unix-to-Windows path conversion for cygpath/Git Bash environments. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add planHistory.ts for versioned plan storage (auto-save on review) - Add planDiff.ts with LCS algorithm for block-level comparison - Add PlanEvolutionPanel.tsx split view component - Add API endpoints: /api/plan/versions, /api/plan/diff, /api/plan/version - Integrate "Evolution" button in editor header 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Combines: - Our evolution panel feature (plan versioning, block-level diff) - Upstream's mermaid diagram support and repo info display 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Implement bidirectional scroll sync between diff columns - Add forwardRef to DiffColumn component for ref access - Create PR documentation for all custom features: - Review tags (@todo, @fix, @verify, @ok...) - [MACRO] flag for cross-document impact - Annotate mode for any markdown file - Persistent validation markers - Plan evolution tracking 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds 5 features that transform Plannotator into a comprehensive document review system for AI-assisted development workflows:
1. Review Tags
Methodology-based annotation tags for clear AI feedback:
@TODO,@FIX,@CLARIFY,@MISSING,@ADD-EXAMPLE@VERIFY,@VERIFY-SOURCES,@CHECK-FORMULA,@CHECK-LINK@OK,@APPROVED,@LOCKED2. [MACRO] Flag
Toggle to mark annotations with cross-document impact. Signals to AI that related files should be checked.
3. Annotate Mode
Annotate any markdown file (not just plans):
4. Persistent Validation Markers
Save
@OK/@APPROVED/@LOCKEDtags to source files as HTML comments:5. Plan Evolution Tracking
Version comparison with git-diff style split view:
Files Changed
packages/core/types.ts,packages/ui/components/AnnotationToolbar.tsxpackages/ui/components/AnnotationToolbar.tsxpackages/server/annotate.ts,apps/hook/commands/plannotator-annotate.mdpackages/core/markers.tspackages/core/planDiff.ts,packages/server/planHistory.ts,packages/ui/components/PlanEvolutionPanel.tsxTest Plan
Screenshots
See individual PR documentation in
docs/folder for detailed descriptions.🤖 Generated with Claude Code