[Proposal] chore: add json repair when model return invalid json #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is a fake code and have compile issue, please share me the idea and I may help create another PR for that. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
we know that when model generate jsons it sometimes throws an invalid json string which could stop all actions and pollute context which makes users have to clear all memorys and redo everything from start. Actually inside of Claude-code they have some way to process it (even claude could also sometimg make this mistake) , but when use claude-bridge, it will throw eariler. So I suggest we may do the same thing as agent internally do. Or shall we return the raw string to agent directly but not parse it from our end? Which should also solve the problem