Absolute path in multiparse fix#15
Open
christopher-schroeder wants to merge 1 commit intobahlolab:mainfrom
Open
Absolute path in multiparse fix#15christopher-schroeder wants to merge 1 commit intobahlolab:mainfrom
christopher-schroeder wants to merge 1 commit intobahlolab:mainfrom
Conversation
Contributor
|
This one is a little trickier. I might have to add a few additional checks and warnings on this - the difficulty with relative pathing is that when the manifest is moved, the file no longer works. I'm happy to add this in, but will want to just make sure that superSTR produces reasonable error messages when that file is shifted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an absolute path missing in the multiparse script. This leads to an missing key error when using relative pathes in the manifest.