delete redundancy check for path at DeleteDirectory and DiskUsage#855
Open
baobaoyeye wants to merge 3 commits intobaidu:masterfrom
Open
delete redundancy check for path at DeleteDirectory and DiskUsage#855baobaoyeye wants to merge 3 commits intobaidu:masterfrom
baobaoyeye wants to merge 3 commits intobaidu:masterfrom
Conversation
yvxiang
approved these changes
Feb 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
（1）NameSpace::NormalizePath 这个函数会默认加上 “/”因此这两个验证都是冗余的，
（2）因为DeleteDirectory的时候如果传一个空字符串就把“/”都删掉太坑，因此提到NormalizePath前面