Fix a null pointer dereference bug in function parse_msg#250
Open
mugitya03 wants to merge 1 commit intobaidu:masterfrom
Open
Fix a null pointer dereference bug in function parse_msg#250mugitya03 wants to merge 1 commit intobaidu:masterfrom
mugitya03 wants to merge 1 commit intobaidu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of the bug
The function parse_msg may return a null value.
In function
field2json, the return value fromparse_msgat line 214 is assigned to the pointerjsonand returned to the caller at line 235.Then, in function
parse_msg, the return value fromfield2jsonat line 269 is assigned tofield_jsonand dereferenced without null check at line 270, causing a null pointer dereference bug.rapidjson::Value* field_json = field2json(msg, field, allocator); root->AddMember(name, *field_json, allocator); // NPD here delete field_json;Fix
I add a null check after calling the function
field2json.