issue #1038: enable leveldb posix log to switch and evict oldest one#1084
Open
caijieming-ng wants to merge 1 commit intobaidu:masterfrom
Open
issue #1038: enable leveldb posix log to switch and evict oldest one#1084caijieming-ng wants to merge 1 commit intobaidu:masterfrom
caijieming-ng wants to merge 1 commit intobaidu:masterfrom
Conversation
Collaborator
00k
suggested changes
Nov 24, 2016
| } | ||
| } // evict oldest log | ||
| } // new log open suc | ||
| } |
Collaborator
There was a problem hiding this comment.
mutex should be released here.
| va_copy(backup_ap, ap); | ||
| pl += vsnprintf(pl, limit - pl, format, backup_ap); | ||
| va_end(backup_ap); | ||
| cur_log_size_ += (pl >= limit) ? 30000: (pl - logbuf_); |
Collaborator
There was a problem hiding this comment.
It is better to get cur_log_size through the return value of PosixLogger::Logv to reduce duplicate calculation and memory copy.
| log_count_(log_count), | ||
| cur_log_size_(0), | ||
| logger_(NULL), | ||
| logbuf_(new char[30000]) {} |
Collaborator
There was a problem hiding this comment.
log_list_ should be initialized by list the directory.
Collaborator
|
First of all, 'issue #1038' is not an issue but a PR; Why & What in human language first and then the code |
Collaborator
|
kan bu donga |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.