Skip to content

Fix move_tabs route argument causing 500 error #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xunoaib wants to merge 3 commits into from
Closed

Fix move_tabs route argument causing 500 error #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0d2737
Fix `move_tabs` route argument causing 500 error
xunoaib Oct 4, 2025
955fa3a
Convert environment variable ports to integers
xunoaib Feb 7, 2026
1b00489
Make MAX_HTTP_PORT inclusive
xunoaib Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions brotab/env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ def http_iface():


def min_http_port():
return environ.get('MIN_HTTP_PORT', DEFAULT_MIN_HTTP_PORT)
return int(environ.get('MIN_HTTP_PORT', DEFAULT_MIN_HTTP_PORT))


def max_http_port():
return environ.get('MAX_HTTP_PORT', DEFAULT_MAX_HTTP_PORT)
return int(environ.get('MAX_HTTP_PORT', DEFAULT_MAX_HTTP_PORT))


def load_dotenv(filename=None):
Expand Down
2 changes: 1 addition & 1 deletion brotab/inout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@


def get_mediator_ports() -> Iterable:
return range(min_http_port(), max_http_port())
return range(min_http_port(), max_http_port() + 1)


def get_available_tcp_port(start=1025, end=65536, host='127.0.0.1'):
Expand Down
2 changes: 1 addition & 1 deletion brotab/mediator/http_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def _setup_routes(self) -> None:
self.app.route('/shutdown', methods=['GET'])(self.shutdown)
self.app.route('/list_tabs', methods=['GET'])(self.list_tabs)
self.app.route('/query_tabs/<query_info>', methods=['GET'])(self.query_tabs)
self.app.route('/move_tabs/<query_info>', methods=['GET'])(self.move_tabs)
self.app.route('/move_tabs/<move_triplets>', methods=['GET'])(self.move_tabs)
self.app.route('/open_urls/<int:window_id>', methods=['POST'])(self.open_urls)
self.app.route('/update_tabs', methods=['POST'])(self.update_tabs)
self.app.route('/open_urls', methods=['POST'])(self.open_urls)
Expand Down