fix: viewInsets should not be updated on keyboard open/close #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did happen
When updating the lib to ^0.9.0, a golden test failed. The problem occured with the opening of the keyboard during the test, that removed the SafeArea padding.
Why did it happen
The version 0.9.0 introduced a change on how the view "paddings" (
padding,viewPadding,viewInsets) were updated on keyboard open close. TheviewPaddingis not updated when the keyboard opens:Sources:
📺 Padding, ViewPadding, and ViewInsets, Oh My! | Decoding Flutter
DartPad demo
viewPadding property
Changes