Slightly refactor context retrieval #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make this more scalable, as we add more handlers for retrieving context, we can use a `getHandler` method that can provide the relevant handler. This then allows us to pass around that handler, not worrying what it is, just that it's doing its job.
To better improve visibility of which context retrieval handler has been used, we can add a `name` to each handler that can be logged when retrieving. In the case of our fallback to OpenGraph, we can log a slightly more appropriate message.
jamietanna
force-pushed
the
refactor/context-handler
branch
from
13bc5dc to
719ef68
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.