-
Notifications
You must be signed in to change notification settings - Fork 103
Add payWithToken Function for ERC20 Token Payments #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
spencerstock
wants to merge
12
commits into
master
Choose a base branch
from
payWithToken-changes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🟡 Heimdall Review Status
|
- Add PaymentSDKConfig type for advanced SDK configuration - Remove redundant walletUrl from PaymentOptions and SubscriptionOptions - Update pay() and subscribe() to accept sdkConfig parameter - Update createEphemeralSDK to merge sdkConfig with defaults - Update executePaymentWithSDK signature to accept sdkConfig - Add test coverage for sdkConfig parameter - Fix existing tests to match new function signatures
6c64241 to
81cea6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Added
payWithTokenfunction to enable ERC20 token payments across multiple chains, extending beyond the existing USDC-only payment functionality.Key changes:
payWithTokenAPI: Supports ERC20 token transfers with customizable paymaster configuration across multiple chains (Base, Optimism, Arbitrum, Polygon, Avalanche, BSC)getPaymentStatus: Automatically extracts token transfer details from transaction logs with proper chain contextHow was this tested?
Test coverage for:
payWithTokenfunction with valid/invalid inputsHow can reviewers manually test these changes?
getPaymentStatussection auto-populates with transaction IDDemo/screenshots