fix(account-sdk): validate capabilities filter hex strings #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🟡 Heimdall Review Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR tightens input validation in assertGetCapabilitiesParams to ensure the optional filter array contains valid hex strings.
Previously, filter entries were accepted if they were strings that started with 0x (e.g. 0xgg would pass).
Now, filter entries must pass viem’s isHex check.
Added a regression test to ensure invalid hex values like 0xgg are rejected.
How did you test your changes?
Updated/added unit test coverage in packages/account-sdk/src/sign/base-account/utils.test.ts (added case for invalid filter entry 0xgg).
How to verify: yarn workspace @base-org/account test