Skip to content

Conversation

@montycheese
Copy link
Collaborator

@montycheese montycheese commented Jan 14, 2026

Summary

Add a test toggle for sub account funding mode in the add sub account test page. This is needed because previously spend-permission was set as the default mode, which was forcing the popup on every first txn while testing
Screenshot 2026-01-14 at 11 05 26 AM

How did you test your changes?

Manually in playground

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 14, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@montycheese montycheese requested review from ajhodges, cb-jake, fan-zhang-sv and stephancill and removed request for stephancill January 14, 2026 16:05
@montycheese montycheese force-pushed the subaccount-funding-switch branch from 4456d97 to 9825932 Compare January 14, 2026 16:07
@montycheese montycheese enabled auto-merge (squash) January 14, 2026 16:12
@montycheese montycheese merged commit c26f23f into master Jan 14, 2026
9 checks passed
@montycheese montycheese deleted the subaccount-funding-switch branch January 14, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants