Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
meyer9
commented
Jan 22, 2026
|
|
||
| startedBlockSignal <- payloads[i].Number + 1 | ||
|
|
||
| time.Sleep(time.Until(startTime.Add(f.options.BlockTime))) |
Collaborator
Author
There was a problem hiding this comment.
previously, validator benchmark wasn't sleeping (also caused an issue with Reth processing spikes)
mw2000
approved these changes
Jan 22, 2026
Collaborator
|
Review Error for mw2000 @ 2026-01-22 19:58:30 UTC |
mw2000
previously approved these changes
Jan 22, 2026
Approved review 3694865793 from mw2000 is now dismissed due to new commit. Re-request for approval.
mw2000
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
startedBlockSignalTesting
Tested with rbuilder and base-node-reth