-
Notifications
You must be signed in to change notification settings - Fork 90
feat: add block metering RPC endpoints #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
niran
wants to merge
7
commits into
main
Choose a base branch
from
meter-block
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add base_meterBlockByHash and base_meterBlockByNumber RPC methods that re-execute a block and return timing metrics for EVM execution and state root calculation. - Add MeterBlockResponse and MeterBlockTransactions types - Rename meter module to bundle, add new block module for block metering - Include per-transaction timing and gas usage data
Collaborator
🟡 Heimdall Review Status
|
BrianBland
reviewed
Dec 3, 2025
Add unit tests for meter_block function and RPC tests for meterBlockByHash and meterBlockByNumber endpoints using TestHarness to build real blocks via the engine API. Also rename meter.rs to bundle.rs to match implementation structure.
Signer recovery can be parallelized, so it should be measured separately from EVM execution time. This adds signer_recovery_time_us to MeterBlockResponse and moves signer recovery before the execution loop.
Add notes about: - Pruned parent state will return an error - Older blocks may have slower state root calculation due to uncached trie nodes
Remove strict equality check for signer recovery time on empty blocks since timing overhead can result in non-zero values.
Instead of requiring the caller to pass a state provider and parent header separately, meter_block now accepts a provider that implements both StateProviderFactory and HeaderProvider. This allows the function to fetch the parent header and state internally, resulting in a cleaner API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add base_meterBlockByHash and base_meterBlockByNumber RPC methods that re-execute a block and return timing metrics for EVM execution and state root calculation.