Add support for EncryptedRichText #512
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, all.
I’ve been building a new product, and I want to use Lexxy as my default rich text editor.
I’m encrypting almost everything in my app by default, but it seems the temporary rendering method did not support encrypted ActionText fields.
I know this will likely be sorted upstream once ActionText supports adapters, but in the meantime, I need Lexxy to work with encrypted fields.
Switching to
to_htmlseems to work, and the test suite is all green. I’ve added one test to explicitly hit the encrypted field path. Otherwise, I’m not entirely certain what other tests would be valuable here. (I was mostly concerned whether I broke attachment functionality.)This commit can likely be trimmed down if we don’t need to do testing beyond the fact that Lexxy can handle encrypted fields.
Also, not sure how to handle encryption-related secrets in a friendly manner for testing purposes in this context. Hard-coding in
config/application.rboffends my sensibilities. But this feels like a higher-level CI decision beyond the scope of this PR.Your feedback is welcome.