Permit zero in cuttlefish duration datatype #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a duration, the current regular expression for "integer" prohibits values that have a leading '0'. This also include the value "0ms", such as in the AAE throttle setting
anti_entropy.throttle.tier1.delay = 0ms.The
list_to_integercall in the integer definition deals with the leading zeros properly. However, if it is desired to prohibit leading zeros for aesthetic reasons while permitting the value '0ms', the regular expression( ([1-9] [0-9]* ) / "0" )can be used.