getting current_command with both newer and older rebar versions#99
Open
vspy wants to merge 1 commit intobasho:developfrom
Open
getting current_command with both newer and older rebar versions#99vspy wants to merge 1 commit intobasho:developfrom
vspy wants to merge 1 commit intobasho:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point rebar made
current_commandavailable throughrebar_config:get_xconfinstead ofrebar_config:get. This resulted in behaviour discussed at basho/riak-erlang-client#151 when building anything that depends on riak-erlang-client with newer rebar versions.This commit fixes it without loosing compatibility with older rebar versions.