Skip to content

fix(cli): preserve default in promptYesNo for invalid input #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Atman36 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): preserve default in promptYesNo for invalid input #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/agentplane/src/cli/prompts.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,14 @@ describe("cli/prompts", () => {
await expect(promptYesNo("Continue", true)).resolves.toBe(false);
});

it("promptYesNo falls back to default for invalid input", async () => {
mocks.state.nextAnswer = "definitely";
await expect(promptYesNo("Continue", true)).resolves.toBe(true);

mocks.state.nextAnswer = "definitely";
await expect(promptYesNo("Continue", false)).resolves.toBe(false);
});

it("promptInput trims input", async () => {
mocks.state.nextAnswer = " hello ";

Expand Down
5 changes: 4 additions & 1 deletion packages/agentplane/src/cli/prompts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ export async function promptYesNo(prompt: string, defaultValue: boolean): Promis
rl.close();
const trimmed = answer.trim().toLowerCase();
if (!trimmed) return defaultValue;
return ["y", "yes", "true", "1", "on"].includes(trimmed);

if (["y", "yes", "true", "1", "on"].includes(trimmed)) return true;
if (["n", "no", "false", "0", "off"].includes(trimmed)) return false;
return defaultValue;
}

export async function promptInput(prompt: string): Promise<string> {
Expand Down