fix(init): accept all setup-profile presets in CLI flags#6
Open
Atman36 wants to merge 1 commit intobasilisk-labs:mainfrom
Open
fix(init): accept all setup-profile presets in CLI flags#6Atman36 wants to merge 1 commit intobasilisk-labs:mainfrom
Atman36 wants to merge 1 commit intobasilisk-labs:mainfrom
Conversation
📝 WalkthroughWalkthroughA new setup profiles system is introduced, expanding from two fixed profiles ("prod" and "dev") to four configurable presets through a registry-based approach. Changes include documentation updates, new test cases, and core CLI command modifications to support and map these profiles. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/agentplane/src/cli/run-cli.core.init-upgrade-backend.test.ts`:
- Around line 901-911: Add assertions after each successful runCli invocation in
the test "init accepts setup-profile strict variants" to verify that
preset-specific defaults were applied: for the prod-strict run (after runCli
with "--setup-profile", "prod-strict") read the generated configuration (use the
same helper used elsewhere in tests to load repo config or parse the config file
in the repo root created by mkGitRepoRoot) and assert that defaultHooks === true
and defaultStrictUnsafeConfirm === true; for the dev-safe run load that run's
generated config and assert defaultStrictUnsafeConfirm === true (and any other
dev-safe-specific defaults expected). Reference the existing helpers
mkGitRepoRoot, configureGitUser, and runCli to locate where to plug in the
config-load and expect(...) assertions.
Comment on lines
+901
to
+911
| it("init accepts setup-profile strict variants", async () => { | ||
| const root1 = await mkGitRepoRoot(); | ||
| await configureGitUser(root1); | ||
| let code = await runCli(["init", "--yes", "--setup-profile", "prod-strict", "--root", root1]); | ||
| expect(code).toBe(0); | ||
|
|
||
| const root2 = await mkGitRepoRoot(); | ||
| await configureGitUser(root2); | ||
| code = await runCli(["init", "--yes", "--setup-profile", "dev-safe", "--root", root2]); | ||
| expect(code).toBe(0); | ||
| }); |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Test coverage for new presets looks good.
The test correctly validates that prod-strict and dev-safe are accepted by the CLI. Consider adding assertions to verify that preset-specific defaults (e.g., defaultHooks: true for prod-strict, defaultStrictUnsafeConfirm: true for both strict variants) are actually applied in the resulting config.
,
💡 Optional: Verify preset defaults are applied
it("init accepts setup-profile strict variants", async () => {
const root1 = await mkGitRepoRoot();
await configureGitUser(root1);
let code = await runCli(["init", "--yes", "--setup-profile", "prod-strict", "--root", root1]);
expect(code).toBe(0);
+ // Verify prod-strict applies defaultStrictUnsafeConfirm: true
+ const config1 = JSON.parse(await readFile(path.join(root1, ".agentplane", "config.json"), "utf8"));
+ expect(config1.execution?.strict_unsafe_confirm).toBe(true);
const root2 = await mkGitRepoRoot();
await configureGitUser(root2);
code = await runCli(["init", "--yes", "--setup-profile", "dev-safe", "--root", root2]);
expect(code).toBe(0);
+ // Verify dev-safe applies defaultStrictUnsafeConfirm: true
+ const config2 = JSON.parse(await readFile(path.join(root2, ".agentplane", "config.json"), "utf8"));
+ expect(config2.execution?.strict_unsafe_confirm).toBe(true);
});📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| it("init accepts setup-profile strict variants", async () => { | |
| const root1 = await mkGitRepoRoot(); | |
| await configureGitUser(root1); | |
| let code = await runCli(["init", "--yes", "--setup-profile", "prod-strict", "--root", root1]); | |
| expect(code).toBe(0); | |
| const root2 = await mkGitRepoRoot(); | |
| await configureGitUser(root2); | |
| code = await runCli(["init", "--yes", "--setup-profile", "dev-safe", "--root", root2]); | |
| expect(code).toBe(0); | |
| }); | |
| it("init accepts setup-profile strict variants", async () => { | |
| const root1 = await mkGitRepoRoot(); | |
| await configureGitUser(root1); | |
| let code = await runCli(["init", "--yes", "--setup-profile", "prod-strict", "--root", root1]); | |
| expect(code).toBe(0); | |
| // Verify prod-strict applies defaultStrictUnsafeConfirm: true | |
| const config1 = JSON.parse(await readFile(path.join(root1, ".agentplane", "config.json"), "utf8")); | |
| expect(config1.execution?.strict_unsafe_confirm).toBe(true); | |
| const root2 = await mkGitRepoRoot(); | |
| await configureGitUser(root2); | |
| code = await runCli(["init", "--yes", "--setup-profile", "dev-safe", "--root", root2]); | |
| expect(code).toBe(0); | |
| // Verify dev-safe applies defaultStrictUnsafeConfirm: true | |
| const config2 = JSON.parse(await readFile(path.join(root2, ".agentplane", "config.json"), "utf8")); | |
| expect(config2.execution?.strict_unsafe_confirm).toBe(true); | |
| }); |
🤖 Prompt for AI Agents
In `@packages/agentplane/src/cli/run-cli.core.init-upgrade-backend.test.ts` around
lines 901 - 911, Add assertions after each successful runCli invocation in the
test "init accepts setup-profile strict variants" to verify that preset-specific
defaults were applied: for the prod-strict run (after runCli with
"--setup-profile", "prod-strict") read the generated configuration (use the same
helper used elsewhere in tests to load repo config or parse the config file in
the repo root created by mkGitRepoRoot) and assert that defaultHooks === true
and defaultStrictUnsafeConfirm === true; for the dev-safe run load that run's
generated config and assert defaultStrictUnsafeConfirm === true (and any other
dev-safe-specific defaults expected). Reference the existing helpers
mkGitRepoRoot, configureGitUser, and runCli to locate where to plug in the
config-load and expect(...) assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns
init --setup-profileCLI validation with the actual preset set used by init flow.Problem
The init flow supports
prod,prod-strict,dev, anddev-safe, but CLI flag validation for--setup-profileallowed onlyprod|dev.Changes
--setup-profileoption choices/value hint to include:prodprod-strictdevdev-safeValidation
npx vitest run packages/agentplane/src/cli/run-cli.core.init-upgrade-backend.test.tspre-commit,pre-push) passedSummary by CodeRabbit
Release Notes
New Features
Documentation
Tests