docs(core,shared): clarify task-id alphabet and utility contracts#7
Open
Atman36 wants to merge 1 commit intobasilisk-labs:mainfrom
Open
docs(core,shared): clarify task-id alphabet and utility contracts#7Atman36 wants to merge 1 commit intobasilisk-labs:mainfrom
Atman36 wants to merge 1 commit intobasilisk-labs:mainfrom
Conversation
📝 WalkthroughWalkthroughThree new utility additions are introduced across shared packages: a function to resolve commit emoji for agents from configuration files with fallback logic, a type guard for identifying plain objects, and a Crockford's base32 alphabet constant for task ID generation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies key documentation clarifications from the external analysis report in a minimal, low-risk PR.
Changes
TASK_ID_ALPHABET(Crockford base32 rationale)isRecordshared guardresolveCommitEmojiForAgentfallback contractValidation
npx vitest run packages/agentplane/src/shared/agent-emoji.unit.test.ts packages/core/src/config/config.test.tspre-commit,pre-push) passedSummary by CodeRabbit
New Features
Improvements