Update example#3
Update example#3Lecrapouille wants to merge 4 commits intobastianhjaeger:masterfrom Lecrapouille:master
Conversation
|
Thanks for your contribution! I added a PR with 2 additional commits for fixing the MAcOS build issue here Note:
Hence I added this path to the cmake. On linux this path is used by default. On MacOS apparently not. I will leave some more comments next on the code. |
bastianhjaeger
left a comment
There was a problem hiding this comment.
Thanks! Looking forward for this.
src/github_actions_gtest_example.cpp
Outdated
There was a problem hiding this comment.
Please revert. Not part of the PR issue.
There was a problem hiding this comment.
Yes not part of the PR, you're right but also no because do you really want searching your own include in system paths first ? This makes sense for library for example. Have you already reverted on your patch ?
src/info.cpp
Outdated
There was a problem hiding this comment.
Please revert. Not part of the PR issue.
There was a problem hiding this comment.
Please revert. Not part of the PR issue.
test/AllTests.cpp
Outdated
There was a problem hiding this comment.
Why bringing in gmock everywhere? Seems not to be needed, right?
I probably do not mind, but I am curious.
There was a problem hiding this comment.
ok. I did not reaaly look at your gtest code. My main looks like:
#include <gtest/gtest.h>
// #include <gmock/gmock.h>
int main(int argc, char *argv[])
{
// The following line must be executed to initialize Google Mock
// (and Google Test) before running the tests.
::testing::InitGoogleMock(&argc, argv);
return RUN_ALL_TESTS();
}
|
@bastianhjaeger |
No description provided.