dz3 #2
Open
dz3 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batiaev
reviewed
Oct 1, 2018
Owner
batiaev
left a comment
batiaev
left a comment
There was a problem hiding this comment.
вечер добрый, по домашней работе все хорошо, но есть спорные моменты типа сдвига при загрузке данных
| @Override | ||
| public String getMessages(int count, int offset) { | ||
| StringBuilder messages = new StringBuilder(); | ||
| if (count > 0 && offset >= 0 && offset < messagesOffsets.size()) { |
Owner
There was a problem hiding this comment.
не совсем ясно как удобно выделять сдвиг так как длина сообщений может быть различна
Author
There was a problem hiding this comment.
Добрый день!
При старте я зачитываю файл с историе и запоминаю все сдвиги для каждого сообщения. Потом при новых собщениях пополняю лист со сдвигами. Соответственно всегда могу зачитывать историю с нужного сообщения
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.