Skip to content
This repository was archived by the owner on Apr 7, 2024. It is now read-only.

Comments

Add support for release candidates#11

Open
kkiningh wants to merge 1 commit intobazelbuild:masterfrom
kkiningh:master
Open

Add support for release candidates#11
kkiningh wants to merge 1 commit intobazelbuild:masterfrom
kkiningh:master

Conversation

@kkiningh
Copy link

@kkiningh kkiningh commented Oct 4, 2018

Resolves issue #10. Might want to refactor a tiny bit so that upgrading the release candidate means only changing the version string and not the url.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@kkiningh
Copy link
Author

kkiningh commented Oct 4, 2018 via email

@googlebot
Copy link

CLAs look good, thanks!

@kkiningh
Copy link
Author

kkiningh commented Oct 4, 2018

Is the build failure related to my pull request? If there's something I should change let me know.

@philwo
Copy link
Member

philwo commented Nov 19, 2018

Hi @kkiningh,

thanks, that looks pretty good! Don't worry about the test - I think our current Travis setup is a bit broken. I'll ping this PR when it should work again, so we can rerun the tests on this one (although I don't see any issues).

@philwo
Copy link
Member

philwo commented Dec 3, 2018

@kkiningh Sorry for the delay in merging :( Would you mind rebasing your PR? I'll merge it then! Otherwise I could also just apply your proposed changes to the current file myself (but then it wouldn't be in your name, so I wanted to check). Let me know. :)

@kkiningh
Copy link
Author

kkiningh commented Dec 3, 2018

Feel free to apply the changes yourself! I'm on vacation and won't be able to get to it until after Christmas.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants