Document errors returned by Execution/WaitExecution#225
Document errors returned by Execution/WaitExecution#225Yannic wants to merge 2 commits intobazelbuild:mainfrom
Conversation
|
@ulfjack PTAL |
|
Ping? |
| // (e.g., because | ||
| // [Execute][build.bazel.remote.execution.v2.Execution.Execute] never | ||
| // returned that value, or because the action was already executed and | ||
| // returned the result). |
There was a problem hiding this comment.
Buildbarn automatically terminates execution of actions in case it has not observed any clients during the last minute that have called Execute() or WaitExecution() on it. This means that a client could also get NOT_FOUND in that case.
Maybe worth calling it out? Or is that too oddly specific?
There was a problem hiding this comment.
I agree that the case of cancelled actions should be explicitly documented here.
I'd like some clarification around separating the Operation error code from the Execution error code. If a client asks for an operation that was completed (or cancelled) in the past, the server may respond with NOT_FOUND if it has already cleared the state related to that Operation, but it is also allowed to respond with the completed Operation.
There was a problem hiding this comment.
Sorry for the super long delay here. PTAL
3 participants
No description provided.