Skip to content

Add GITSHA1 digest function. #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjgq merged 2 commits into from
Jan 20, 2026
Merged

Add GITSHA1 digest function. #352

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa1dffe
Add GITSHA1 digest function.
jgalmes2 Nov 21, 2025
7ba7909
Add GITSHA1 digest function.
jgalmes2 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions build/bazel/remote/execution/v2/remote_execution.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2150,6 +2150,13 @@ message DigestFunction {
// The BLAKE3 hash function.
// See https://github.com/BLAKE3-team/BLAKE3.
BLAKE3 = 9;

// Identical to SHA1, except that "blob ${sizeBytes}\0" is prepended to
// the blob's contents before hashing, where ${sizeBytes} corresponds to
// the decimal size of the original blob. This allows hashes of files to
Copy link
Contributor

@mostynb mostynb Dec 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO "decimal size" makes this sound like a non-integer value. Would something like "where ${sizeBytes} is the number of bytes in the original blob" be better?

Copy link
Collaborator

@EdSchouten EdSchouten Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explicitly used the term "decimal", because it shouldn't be provided in little/big endian binary form, or as hexadecimal characters, or ...

Copy link
Contributor

@mostynb mostynb Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "decimal integer size" ?

Copy link
Collaborator

@EdSchouten EdSchouten Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ambivalent.

Copy link
Collaborator

@tjgq tjgq Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have multiple approvals and the sole remaining disagreement is on how the comment is worded (which can always be amended later), I'll merge this now.

// be converted from and to the ones used by the Git version control
// system.
GITSHA1 = 10;
}
}

Expand Down