Skip to content

Make SpliceBlobRequest.blob_digest mandatory #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjgq merged 2 commits into from
Jan 13, 2026
+6 −3
Merged

Make SpliceBlobRequest.blob_digest mandatory #356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
743040b
SpliceBlobRequest.blob_digest should be required
tyler-french Dec 18, 2025
db45d6d
Fix comment formatting in remote_execution.proto
tyler-french Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions build/bazel/remote/execution/v2/remote_execution.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1995,15 +1995,18 @@ message SpliceBlobRequest {
// omitted.
string instance_name = 1;

// Expected digest of the spliced blob. The client SHOULD set this field due
// Expected digest of the spliced blob. The client MUST set this field due
// to the following reasons:
// 1. It allows the server to perform an early existence check of the blob
// before spending the splicing effort, as described in the
// [ContentAddressableStorage.SpliceBlob][build.bazel.remote.execution.v2.ContentAddressableStorage.SpliceBlob]
// or existing chunks that assemble the blob before spending the splicing
// effort, as described in the [ContentAddressableStorage.SpliceBlob][build.bazel.remote.execution.v2.ContentAddressableStorage.SpliceBlob]
// documentation.
// 2. It allows servers with different storage backends to dispatch the
// request to the correct storage backend based on the size and/or the
// hash of the blob.
// 3. If chunking information already exists for the blob, it allows
// the server to keep the existing chunking information or replace it with
// new chunking information.
Digest blob_digest = 2;

// The ordered list of digests of the chunks which need to be concatenated to
Expand Down