Dynamic feature: do not filter out the dex files #437
+824
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from PR bazelbuild#271 (bazelbuild/rules_android).
snazhmudinov
commented
Dec 24, 2025
| # Multiple mappings, merge them | ||
| merged_proguard_mapping = ctx.actions.declare_file(ctx.label.name + "_merged_proguard.map") | ||
|
|
||
| # TODO: this isn't working, because `proguard_maps_merger` doesn't exist in the toolchain. |
Contributor
Author
There was a problem hiding this comment.
I don't know if the merging can be done by simple concatenation of the files. If yes, then I could add that tool and expose it via the toolchain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag to keep the dex files in feature split APK.
The feature activity can be launched on demand, using the following steps:
0. Make sure you have a connected device/emulator up and running
cd rules_android/examples/bundle && bazel build //app:assets--bundle=bazel-bin/app/assets_unsigned.aab
--output=assets.apks
--connected-device
Load Feature